Masatake Iwasaki

Some tests in the hadoop_add_ldlibpath.bats fails with following error without the fix. ``` [exec] not ok 3 hadoop_add_ldlibpath (simple dupecheck) [exec] # (from function `hadoop_add_colonpath' in file ../../main/bin/hadoop-functions.sh, line 1251,...

Test the patch on Rocky Linux 8 with gcc-toolset-9-gcc. ``` $ echo $LD_LIBRARY_PATH /opt/rh/gcc-toolset-9/root/usr/lib64:/opt/rh/gcc-toolset-9/root/usr/lib:/opt/rh/gcc-toolset-9/root/usr/lib64/dyninst:/opt/rh/gcc-toolset-9/root/usr/lib/dyninst:/opt/rh/gcc-toolset-9/root/usr/lib64:/opt/rh/gcc-toolset-9/root/usr/lib $ mvn test -Pshelltest -Dtest=x ... [exec] Running bats -t hadoop_add_ldlibpath.bats [exec] 1..9 [exec] ok 1...

Thanks, @ashutoshcipher and @aajisaka.

@pan3793 I got following error on building trunk with the patch applied. ``` $ mvn clean install -DskipTests ... [WARNING] Dependency convergence error for org.jetbrains.kotlin:kotlin-stdlib:jar:1.4.0:test paths to dependency are: +-org.apache.hadoop:hadoop-common:jar:3.4.0-SNAPSHOT...

Can you share the way to reproduce the issue? It looks like we can not get expected outcome regardless of the patch due to another reason. ``` $ export HADOOP_OPTS="-XX:OnOutOfMemoryError='kill...

Hmm, hadoop_add_param does not work if the value contains `"`. (`HADOOP_OPTS='-XX:OnOutOfMemoryError="kill -9 %p"'` instead of previous `HADOOP_OPTS="-XX:OnOutOfMemoryError='kill -9 %p'"`) @ashutoshcipher ``` $ export HADOOP_OPTS='-XX:OnOutOfMemoryError="kill -9 %p"' $ echo $HADOOP_OPTS -XX:OnOutOfMemoryError="kill...

It would be nice if you can add test cases to files under hadoop-common-project/hadoop-common/src/test/scripts in order to see if no regression.

You can run the tests by `mvn test -Pshelltest -Dtest=x` on hadoop-common-project/hadoop-common. (You need to install bats for this.)

@ashutoshcipher If your suggestion is to add support spaces enclosed in single quote (`'`) like `-XX:OnOutOfMemoryError='kill -9 %p'`, you should add the statement to [documentation](https://github.com/apache/hadoop/blob/2680f17eb49d7d6e117156108f9a013b38141999/hadoop-common-project/hadoop-common/src/site/markdown/UnixShellGuide.md) and [tests](https://github.com/apache/hadoop/tree/2680f17eb49d7d6e117156108f9a013b38141999/hadoop-common-project/hadoop-common/src/test/scripts) showing the spec.

> add support spaces enclosed in single quote (') and not to support enclosing vars with double quote (`"`)