Tengfei Huang comments

Results 24 comments of


                                            Tengfei Huang

[VL] Unsupported spark function list [please leave a comment if you plan to pick some]

Hi @PHILO-HE I'd like to take filter (array filter), thanks.

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

cc @Ngone51 @jiangxb1987 @cloud-fan Please take a look. Thanks.

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

> > Use LinkedBlockingDeque instead of LinkedBlockingQueue for the results. > > Another possible solution to consider would be collecting the `FailureFetchResult` in a separate collection (which can be `LinkedBlockingQueue`)...

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

> Why we need the feature flag? I fail to see what we lose when this is always on but I can see the flag adds some extra complexity. Hi...

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

Thanks for sharing your opinions. Removing the feature flag. cc @attilapiros @LuciferYang @jiangxb1987

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

Hi @attilapiros pls take another look. Thanks.

[SPARK-52395][CORE] Fast fail when shuffle fetch failure happens

Thanks for your review @LuciferYang @jiangxb1987 @Ngone51 @attilapiros @mridulm

[GLUTEN-7079][VL] Fix metrics for InputIteratorTransformer of broadcast exchange

cc @zhztheplayer @ulysses-you can you please help review this PR? Thanks.

[GLUTEN-7079][VL] Fix metrics for InputIteratorTransformer of broadcast exchange

Hi @zhztheplayer, can you please take another look? I tried to make it share the same output row counts metrics from child plan and modified the previous output metrics as...

[GLUTEN-7079][VL] Fix metrics for InputIteratorTransformer of broadcast exchange

gentle ping @zhztheplayer , can you please take another look? Thanks.