incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-7079][VL] Fix metrics for InputIteratorTransformer of broadcast exchange

Open ivoson opened this issue 1 year ago • 8 comments

What changes were proposed in this pull request?

Fix issue https://github.com/apache/incubator-gluten/issues/7079 collecting metrics for InputIteratorTransformer of broadcast exchange.

How was this patch tested?

UT added.

ivoson avatar Sep 09 '24 08:09 ivoson

https://github.com/apache/incubator-gluten/issues/7079

github-actions[bot] avatar Sep 09 '24 08:09 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Sep 09 '24 08:09 github-actions[bot]

cc @zhztheplayer @ulysses-you can you please help review this PR? Thanks.

ivoson avatar Sep 09 '24 08:09 ivoson

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 08 '24 06:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 10 '24 02:10 github-actions[bot]

Hi @zhztheplayer, can you please take another look? I tried to make it share the same output row counts metrics from child plan and modified the previous output metrics as data being consumed which might sound more reasonable when the data got read multiple times.

ivoson avatar Oct 10 '24 02:10 ivoson

gentle ping @zhztheplayer , can you please take another look? Thanks.

ivoson avatar Oct 18 '24 02:10 ivoson

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 22 '24 03:10 github-actions[bot]

@ivoson Do you want to show some screenshots on Spark UI about the difference made by this PR? Thanks.

zhztheplayer avatar Oct 30 '24 07:10 zhztheplayer

@ivoson Do you want to show some screenshots on Spark UI about the difference made by this PR? Thanks.

Sure, let me add some screenshots.

Updated PR description. cc @zhztheplayer

ivoson avatar Oct 31 '24 04:10 ivoson