Iván Valdés Castillo

Results 430 comments of Iván Valdés Castillo

@henrybear327, I think the second part (ensuring that the dependencies across the Go submodules have consistent versions) is outside the scope of this issue. If you agree, I'd like to...

@ahrtr, @jmhbnz, as I'm moving the `govuln` check to the `Makefile` (so we can port it to a prow job), I realized there are two options: 1. Add a `verify-govuln`...

@jmhbnz, I hope you don't mind, but I'm implementing it as a different target :pray:. This way we have a different prow job that runs exclusively this check.

There's no need to backport this. It already works with GitHub actions for both branches. Also, as Benjamin pointed out, we don't need multi-module checking for 3.4 as there's a...

Reopening, as I found out that the release-3.5 branch is not running properly. I'm about to open a pull request to address the issue.

@ahrtr, @serathius, thoughts on replacing `gofmt` with [`gofumpt`](https://github.com/mvdan/gofumpt)?

I also noticed this while working on etcd-io/etcd#18649. I tried multiple browsers, and the page is stuck on "Loading...". I'm a bit unfamiliar with this repository. By peeking at the...

> I am on it. @henrybear327, you're doing it as part of the weekly dependency bump, right?

Thanks, @henrybear327. Check https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/etcd-io_etcd/18504/pull-etcd-verify/1828149502016491520. I think you'll need to address that along with the dependency bump (what Benjamin was referring to)