Iván Todorovich

Results 89 comments of Iván Todorovich

fix proposed here: - https://github.com/OCA/pos/pull/1211

Thanks! CI is red due to some other module tests, AFAICS. I'll try to rebase, but it might fail depending on the PR permissions. If it does fail, could you...

Great! All is green now :) All we need now is another person's review (to reach the 2 approvals). Generally, having patience and reviewing other people's PR can help on...

Hey @BT-dmoreno , thanks for migrating this module! I haven't done a full review yet, though.. could you squash (all or some of) your migration commits into `[16.0][MIG] pos_event_sale: Migration...

Thanks @BT-dmoreno ! It looks like test tours are failing, could you check?

Indeed, it seems related to: `pos_customer_comment` ``` 2024-01-03 10:39:23,225 339 ERROR odoo odoo.addons.pos_customer_comment.tests.test_module: FAIL: TestUi.test_pos_customer_comment Traceback (most recent call last): File "/__w/pos/pos/pos_customer_comment/tests/test_module.py", line 17, in test_pos_customer_comment self.start_tour( File "/opt/odoo/odoo/tests/common.py", line...

Indeed, I've just checked on my side and I also green lights I've just triggered a re-run of the failed job: https://github.com/OCA/pos/actions/runs/7396233081/job/20495822404 and it seems to be green now. It's...