pos icon indicating copy to clipboard operation
pos copied to clipboard

[16.0][ADD] pos_screen_element_custom_size

Open geomer198 opened this issue 1 year ago • 13 comments

This module allows to define custom size values for certain POS screen elements.

geomer198 avatar Feb 20 '24 20:02 geomer198

Interesting module. thanks for sharing ! could you remove the pandoc... .deb file ?

thanks !

Could you check again?

geomer198 avatar Feb 21 '24 15:02 geomer198

Interesting module. thanks for sharing ! could you remove the pandoc... .deb file ? thanks !

Could you check again?

Do you have any idea how the pandoc deb appeared ? I had the same in one of my PR once...

cvinh avatar Feb 21 '24 17:02 cvinh

Interesting module. thanks for sharing ! could you remove the pandoc... .deb file ? thanks !

Could you check again?

Do you have any idea how the pandoc deb appeared ? I had the same in one of my PR once...

Pandoc is added after running pre-commit.

geomer198 avatar Feb 21 '24 17:02 geomer198

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Feb 25 '24 21:02 OCA-git-bot

/ocabot merge nobump

dreispt avatar Mar 22 '24 20:03 dreispt

/ocabot merge nobump

legalsylvain avatar Mar 28 '24 16:03 legalsylvain

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1158-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot avatar Mar 28 '24 16:03 OCA-git-bot

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1158-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Mar 28 '24 16:03 OCA-git-bot

Hi @geomer198 could you rebase and take a look on red ci ? Thanks !

legalsylvain avatar Mar 28 '24 17:03 legalsylvain

hi @legalsylvain could you please check again? Thank you in advance!

ivs-cetmix avatar May 10 '24 14:05 ivs-cetmix

/ocabot merge nobump

legalsylvain avatar May 10 '24 14:05 legalsylvain

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-1158-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot avatar May 10 '24 14:05 OCA-git-bot

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1158-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar May 10 '24 14:05 OCA-git-bot

HI @OCA/pos-maintainers. we have regularly a weird error on OCA/pos CI. Description :

  • The PR is green (all checks are OK)
  • we call ocabot
  • the merge of ocabot fails.
  • when we check the errors, there is an error on OCB, meanwhile odoo is green.

image

  • finally after many tries, it works. (without any code change, or any rebase).

Do you have an idea on how to solve the problem ?

thanks ! cc @ivantodorovich

legalsylvain avatar Jun 06 '24 14:06 legalsylvain

Indeed, I've seen it too. I'll try to investigate in the coming days. It's always related to the pos_order_to_sale_order module, isn't it?

2024-05-10 14:45:44,264 397 ERROR odoo odoo.addons.pos_order_to_sale_order.tests.test_module: FAIL: TestUi.test_pos_order_to_sale_order
Traceback (most recent call last):
  File "/__w/pos/pos/pos_order_to_sale_order/tests/test_module.py", line 36, in test_pos_order_to_sale_order
    self.assertEqual(len(before_orders) + 1, len(after_orders))
AssertionError: 1 != 0

ivantodorovich avatar Jun 24 '24 11:06 ivantodorovich

fix proposed here:

  • https://github.com/OCA/pos/pull/1211

ivantodorovich avatar Jul 01 '24 18:07 ivantodorovich

/ocabot merge nobump

ivantodorovich avatar Jul 02 '24 15:07 ivantodorovich

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-1158-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot avatar Jul 02 '24 15:07 OCA-git-bot

Congratulations, your PR was merged at 8d086d400f9a648c0abf9547d159f599540d023c. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Jul 02 '24 15:07 OCA-git-bot