Iván Todorovich

Results 89 comments of Iván Todorovich

CI is red, could you check please? 🙏🏻

Thanks a lot @Freni-OSI overall it looks good :) could you check my suggestions?

Rebased on top of https://github.com/shopinvader/odoo-shopinvader/pull/1172 to fix conflicts. I'll rebase again once that PR is merged

> Rebased on top of #1172 to fix conflicts. I'll rebase again once that PR is merged Rebased on top of `14.0`, since #1172 was merged

@hparfr this is what we've discussed in https://github.com/shopinvader/odoo-shopinvader/pull/1110

Wasn't this intentional, though? With this change, one can easily re-activate unwanted shopinvader.variants. Imagine you have a product and a shopinvader binding. After a while you disable the binding. After...

Indeed, even `13.0` branch is red 🤔 Maybe try updating from copier template?

So, tests are red becase installing `l10n_fr` coa breaks everything up. I guess this is normal, tests are meant to run without localizations installed. As for how to solve it,...