[14.0][ADD] shopinvader_l10n_fr

[ivantodorovich]

New module to implement l10n_fr for shopinvader.

• Expose siret fields on address and customer services.

[simahawk]

Tests are :red_circle: . As you are there, can you turn off logging of requests for vcr.py on elasticsearch tests?

[ivantodorovich]

So, tests are red becase installing l10n_fr coa breaks everything up. I guess this is normal, tests are meant to run without localizations installed.

As for how to solve it, I tried to set it as a rebel module but it seems manifestoo -d . check-licenses doesn't like that.

I'm wondering:

• Does it make sense that we merge this module here? I don't expect we'll have much shopinvader-l10n modules but maybe we need separate localization based repositories for them, like we have in OCA?
• In any case, @sbidoul any idea what's going on with manifestoo here? It seems not to like rebel modules

[sbidoul]

what's going on with manifestoo here? It seems not to like rebel modules

I suppose we need to pass INCLUDE and EXCLUDE the license and dev status checks. The docs for the select options is here. That will need to be done in the OCA template too.

[sbidoul]

Or maybe we should put the license and dev status checks in separate jobs.

[ivantodorovich]

Thanks @sbidoul

This seems to work. I don't really like the multi line script though.

- name: Check licenses
  run: |
    if [ -n "$INCLUDE" ]
    then manifestoo --select-include "$INCLUDE" check-licenses
    else manifestoo -d . --select-exclude "$EXCLUDE" check-licenses
    fi

- name: Check development status
  run: |
    if [ -n "$INCLUDE" ]
    then manifestoo --select-include "$INCLUDE" check-dev-status --default-dev-status=Beta
    else manifestoo -d . --select-exclude "$EXCLUDE" check-dev-status --default-dev-status=Beta
    fi

Maybe we could do this in oca-ci with a oca_run_manifestoo bin, to keep the github action cleaner.

Then it'd be like this:

- name: Check licenses
  run: oca_run_manifestoo check-licenses
- name: Check development status
  run: oca_run_manifestoo check-dev-status --default-dev-status=Beta

What do you think?

[simahawk]

@ivantodorovich what's next?

[ivantodorovich]

@ivantodorovich what's next?

I'd go for adding a oca_run_manifestoo bin in oca-ci image, as mentioned here: https://github.com/shopinvader/odoo-shopinvader/pull/1223#issuecomment-1028332582

Then we could change the repo templates to use it

Would you be ok with it @sbidoul ?

[sbidoul]

This was resolved in https://github.com/OCA/oca-ci/pull/24 and https://github.com/OCA/oca-ci/pull/25. It should be green now.

[ivantodorovich]

Cool! Let's see if it passes🤞🏻

[ivantodorovich]

Yay! it's green 🍏 thanks a lot @sbidoul !

[sebastienbeau]

LGTM (code review) /ocabot merge patch

[shopinvader-git-bot]

@sebastienbeau The merge process could not start, because command git push origin 14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch failed with output:

To https://github.com/shopinvader/odoo-shopinvader
 ! [remote rejected]   14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch -> 14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/test.yml` without `workflow` scope)
error: failed to push some refs to 'https://***@github.com/shopinvader/odoo-shopinvader'

[sebastienbeau]

@ivantodorovich Can you rebase so I can merge it

[ivantodorovich]

This is ready @sebastienbeau

[sebastienbeau]

/ocabot merge patch

Thanks

[shopinvader-git-bot]

@sebastienbeau The merge process could not start, because command git push origin 14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch failed with output:

To https://github.com/shopinvader/odoo-shopinvader
 ! [remote rejected]   14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch -> 14.0-ocabot-merge-pr-1223-by-sebastienbeau-bump-patch (refusing to allow a Personal Access Token to create or update workflow `.github/workflows/test.yml` without `workflow` scope)
error: failed to push some refs to 'https://***@github.com/shopinvader/odoo-shopinvader'

[ivantodorovich]

FTR the issue seems to be related to the permissions given on the bot's github token

[github-actions[bot]]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.