Ivan Ka

Results 538 comments of Ivan Ka

Hi. This is quite an old issue. Could you explain in more details what the definition of done is here? Would be nice if you share some diagrams of your...

Interesting. Did not notice on our CI system. Most likely due to chart size. I'll try to dig

I'm not too sure how to execute unittest against your helm charts. Could you by any chance share commands to execute it ```sh cd prometheus-helm-charts/charts/kube-prometheus-stack helm dependency update helm unittest...

Nice one. I was mainly asking as was not able to understand how to run you charts. Yeah, there is defiantly something there.

I'm currently in the process of diagnosing the leak, and I'm tackling it incrementally, review one change at a time.

Validate PRs - OK https://github.com/helm-unittest/helm-unittest/pull/609/files - OK https://github.com/helm-unittest/helm-unittest/pull/610 - OK https://github.com/helm-unittest/helm-unittest/pull/625/files

So, this PR is related https://github.com/helm-unittest/helm-unittest/pull/589/files#diff-38fe208402640a2855aff9cdb4b5d0b5521fb31582fc2fcff9ce8f589839494a and exactly that lines in `test_suite.go` ```go // (Re)load the chart used by this suite (with logging temporarily disabled) log.SetOutput(io.Discard) chart, _ := v3loader.Load(chartPath)...

Confirmed. All other versions like `0.7`, `0.6`, `0.5` have same memory related issue. So the only version `0.8` actually do not have this leak