Ivan Bella

Results 70 comments of Ivan Bella

For documentation purposes, here is the response in the conversation we had: 1) The tests that test the query plan would need to be changed to handle the one returned...

@billoley Cleaned up those members and constructors. Thanks!

> @ivakegg are you done making changes? i can't tell looking at your latest comments. I think I am.

To be able to test this I had to set some properties in the QueryLogicFactory.xml which I think we should go ahead and add in this PR: web-services/deploy/configuration/src/main/resources/datawave/query/QueryLogicFactory.xml - -...

I think this will get into the accumulo 2.1 branch when we merge integration into it which I believe Keith does periodically.

1) "The feature adds a lot of complexity, for a small convenience." I strongly disagree with this. For all of those that have to maintain our systems, it becomes crutial...

> > See Adam's comment > > Is it still too close? I changed it from `IterationInterruptedException` to `IterationInterruptException`. Might be a bit confusing if they're this close, what do...

Ok, it appears that whole mechanism is basically OBE. So essentially, everywhere we were passing InterationInterruptedException should remain as is. We simply should not be implementing the InterruptibleIterator and hence...

We need to remove the InterruptibleIterator as you have done. What I think is that the additional exception is not what we need here. Instead we should simply make sure...

I had added several comments but then removed them once I figured out what the thought process is here. I think this looks good, but I need to do some...