datawave icon indicating copy to clipboard operation
datawave copied to clipboard

* Refactored Document and TimingMetadata to not extend Attribute

Open ivakegg opened this issue 1 year ago • 2 comments

  • Simplified any logic looking for nested documents

ivakegg avatar Apr 11 '23 12:04 ivakegg

In DocumentProjection, the following constructor arguments and class memebers are no longer used. Is this intentional? If so, they should probably be removed from the constructor and the class.

private final boolean includeGroupingContext;
private final boolean reducedResponse;    
private boolean trackSizes = true;

public DocumentProjection(boolean includeGroupingContext, boolean reducedResponse, boolean trackSizes, Set<String> projections, Projection.ProjectionType projectionType) {
    this.includeGroupingContext = includeGroupingContext;         // no longer used
    this.reducedResponse = reducedResponse;                            // no longer used
    this.projection = new Projection(projections, projectionType);
    this.trackSizes = trackSizes;                                                      // no longer used
}

billoley avatar Dec 20 '23 16:12 billoley

@billoley Cleaned up those members and constructors. Thanks!

ivakegg avatar Feb 14 '24 14:02 ivakegg