Ivar Jönsson

Results 10 comments of Ivar Jönsson

I realize that this might be stale but, It would be relatively simple to add this. I made a draft [implementation](https://github.com/ivario123/nrf-hal-monotonic/blob/master/nrf-hal-common/src/monotonic.rs) making the abstraction agnostic to whether you are using...

@barafael I think that I have finished an [implementation](https://github.com/ivario123/nrf-hal-monotonic/blob/master/nrf-hal-common/src/monotonic.rs) for this The API looks like this at the time of writing and it will not change much. ```rust #![no_main] #![no_std]...

@diondokter Not quite sure how the review process works but figured I'd mention you here since we have discussed earlier PRs

@qwandor Would you mind looking through this?

> Thanks! I've updated this to work with the current master and fixed a bunch of small things. It looks good, except that it doesn't build for nrf51 or nrf52832....

@qwandor it seems that we might need to modify the bits manually or re-write parts of the PAC. As this is a small feature I think that it is better...

> Thanks for working on this! > > I'm easily confused. Should this trait be named `rtic-monotonic`? Or is it more general than that? This is probably a good idea...

> Thanks! We should probably fix the PAC to add the missing fields, but I'm alright with this for now. If at all possible it would be great to test...

Excuse the force push, I resolved the conflicts with a PR instead. I also renamed the user-facing feature to rtic-monotonic as I find it describes the feature better. The feature...

> @qwandor Yeah, meant the feature flag. > > I think we should probably have someone test any `unsafe` and get some good eyes on it before we merge that....