invidious icon indicating copy to clipboard operation
invidious copied to clipboard

[Bug] Index out of bound - video doesn't exist in the playlist

Open tunnckoCore opened this issue 3 years ago • 1 comments

Describe the bug

It's a mirror of popular Bulgarian torrent site for 2 decades. I don't know which instance it tries to get the embed cuz I have the Privacy Redirects Firefox extension which automatically redirects youtube links.

Steps to Reproduce

  1. Go to https://zamunda.ch/index.php
  2. It has usually a youtube embed.

Logs

Title: Index out of bounds (IndexError) Date: 2022-08-05T10:30:09Z Route: /embed/?listType=playlist&list=PLLjHNPsiPC3f9jTm0HhH3OckS6MOSfxGv&index=11&local=true&dark_mode=true Version: 2022.08.03-4ab54f2 @ master

Backtrace

Index out of bounds (IndexError)
  from /usr/share/crystal/src/string.cr:5288:5 in '->'
  from lib/kemal/src/kemal/route.cr:13:9 in '->'
  from src/invidious/helpers/handlers.cr:30:37 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/filter_handler.cr:21:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from src/ext/kemal_static_file_handler.cr:167:15 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call'
  from /usr/share/crystal/src/http/server/handler.cr:28:7 in 'call_next'
  from lib/kemal/src/kemal/init_handler.cr:12:7 in 'process'
  from /usr/share/crystal/src/http/server.cr:500:5 in '->'
  from /usr/share/crystal/src/fiber.cr:146:11 in 'run'
  from ???

Screenshots

It says to report it and as Open Sourcerer i'm reporting it.

image

Additional context

  • Browser (if applicable): Firefox (LibreWolf) latest
  • OS (if applicable): ArchLinux

tunnckoCore avatar Aug 05 '22 10:08 tunnckoCore

The bug is related to the parameter index=11, without it the page "works". Can reproduce on all the instances.

unixfox avatar Aug 05 '22 13:08 unixfox

Oh, yea thanks. Didn't thought about that.

But actually, couldn't the video be resolved somehow based on the index and the playlist?

In anyway, at least a better message would be good enough too, no problem. I rarely have that case.

tunnckoCore avatar Aug 25 '22 22:08 tunnckoCore

There are 10 videos in the playlist, invidious can't magically find a 11th one.

unixfox avatar Aug 26 '22 06:08 unixfox