mike douges
mike douges
Ok checking the code out and removing the trim I get only that test you've mentioned failing: ```bash Summary of all failing tests FAIL packages/react-dom/src/__tests__/CSSPropertyOperations-test.js ● CSSPropertyOperations › should trim...
0 still gets applied with extra white space (heres just a quick vanilla sandbox)   https://codesandbox.io/s/naughty-star-y43ey?file=/index.html do we have enough to go on? what do we want for more...
In this instance yes, however the behaviour wanted is to actually "unset" the CSS variable, having the border change to black is merely the effect of unsetting.
I'll look into this, starting to use the Merged component and getting hit by it :-)
Hey folks! Is the fix in https://github.com/pmndrs/react-three-fiber/pull/2339/files#diff-42e46ec762930e1485e849404cfda91d327e6ee4891ebbb7e9bc7c09f2cd01d0R285 meant to be checking [clientTop](https://developer.mozilla.org/en-US/docs/Web/API/Element/clientTop)? Is the border width the correct value to be looking at? I would have imagined something similar to...
Hey @NimishGopal! There is currently webpack 5 support but true next support still needs work as the current implementation relies on webpack cache groups which isn't available in next. There...
@JakeLane I believe this could also be an issue when it comes doing transformations over nodes that Compiled will be transforming. For example the tokens plugin we are using internally...
Thanks for the contribution! I've left some comments.
Hey @youzi we'd be keen for this contribution - do you need any help? There are a few conflicts now.
Hey @youzi we'd be keen for this contribution - do you need any help? There are a few conflicts now.