Buğra Ekuklu comments

Results 5 comments of


                                            Buğra Ekuklu

Dokka example with multi module Android projects

No comments on this?

Be less NSException-Happy...

I'll submit a pull request, refactoring all of these `NSException`s to `NSError *`s. It will help its Swift compatibility.

Is it a good practice to define constant strings to a listener?

You're right about constructing a new `MetricRegistry` to prefix all of the instrument labels, however for people using Spring Boot Actuator, the `MeterRegistry` (which is different from `MetricRegistry`) object will...

Is it a good practice to define constant strings to a listener?

I could not assert it is safer, but it is simpler indeed. In my case, a prefix would be more than okay. Should you we implement this in #667? This...

Is it a good practice to define constant strings to a listener?

> Could you get away with a [`MeterFilter`](https://static.javadoc.io/io.micrometer/micrometer-core/1.0.5/io/micrometer/core/instrument/config/MeterFilter.html)? As a last resort, we could think about adding a `prefix` argument to the `MicrometerApnsClientMetricsListener` constructor. Both of those would seem a...