Farzin Kazemzadeh

Results 7 comments of Farzin Kazemzadeh

> Thanks for the PR. > > In which version of HTTPX was the `proxy` argument added? > > We should require at least that version at > > https://github.com/pylast/pylast/blob/f4800917c905c9503eebd04e3b74f9fdfafe618c/pyproject.toml#L40-L42...

By the way, we can simplify the instantiation of the HTTPX client. `is_proxy_enabled` checks if the proxy is None or not, and based on that, client gets initialized. We can...

https://github.com/pylast/pylast/pull/487/commits/300320ff1f075c7f93cd665e51964e820acef17c#diff-bdfc4afd1c1f888b812a0b0e0ff710ed101c69370a4634b2430c2d1d3ef97275R199-R210 With this change, the proxy types below will work: ```python "socks5://192.168.1.71:10808" {"https://": "socks5://192.168.1.71:10808"} # (For not breaking old codes) {"https://": httpx.HTTPTransport(proxy="socks5://192.168.1.71:10808")} ```

> Please can you look into it? I'd love to, but due to recent events in my country (Iran), our network has gotten even worse, and I can't run the...

I don't think this is a breaking change. ~The old way of using a proxy is still working and if someone used the multiple proxy one (which I don't think...

@hugovk, when this will be merged?

Thanks — safe travels.