Iñigo Tellaetxe Elorriaga
Iñigo Tellaetxe Elorriaga
My linter was not showing me the E501 problem. Fixing it. Sorry
> We fixed the issue in master, Can you rebase this branch or merge master to this branch? Hi @skoudoro, due to the ongoing discussion, I think I will leave...
Thanks to everyone that took part in the discussion. Shortly: - I followed the indications given by @arokem and @skoudoro, regarding the new namings. - `sh_degree_max` is now `sh_order_max`. -...
> @itellaetxe, everytime you change from `sh_order` to `sh_order_max` in a function argument, you need to add the decorator below: Done. It should be good to go now!
@skoudoro, I completely overlooked the deprecator decorator in the `m` and `n` cases. I will fix it. Sorry!
Thank you @skoudoro for the help with those last decorators! Also thank you for the patience and the good advice to everyone that participated in the discussion. I will try...
Hi, I am Iñigo Tellaetxe, newcomer, and I would like to solve this issue. I read the resources you included, and it does not seem to be very difficult to...
Thanks! I have been reviewing the issue in more detail, and I have a couple of suggestions. I'd like to know your opinion before proceeding: - Since `m` (order) and...
Thanks for the feedback! I will stick to `m_values` and `l_values`. Working on it right now. Will keep you updated.
Hi again, I have been working on the code, trying to be as consistent as possible with the namings we discussed. Now I moved on to the docu, but I...