Itay Shakury

Results 316 comments of Itay Shakury

> When using the LPM Trie, it always returns the longest matching string. A corner case arises when one policy (e.g., policy1) uses a substring of another policy (e.g., policy2)....

as far as I understand using last-applied instead of the live resource was added solely to support deprecated API check. In this case, I think that would be the exception...

> I'll try to create a list of deprecated k8s APIs what did you mean by that?

we have it here: https://github.com/aquasecurity/trivy-db-data/blob/main/k8s/api/k8s-outdated-api.json which is used here: https://github.com/aquasecurity/trivy-checks/blob/83ac3dddea29d16ccd1e84c8c018cffe696f41db/Makefile#L56

do you mean to say that this feature isn't useful anymore? or that our data isn't updated [(I know it isn't)](https://github.com/aquasecurity/trivy-db-data/blob/main/last_updated.json)?

I agree that this feature isn't very important or useful. I wouldn't mind removing it if it's a pain to maintain, but FTR it still is valid: The concept of...

thanks for explaining, it seems like this feature is causing more problems than value. I have a feeling that's because the implementation wasn't "clean" and that it's possible to refactor...

thanks. but the year should be 2019 as the first commit

I have no way to test this. If the community really need this, we can think about adding automated tests, otherwise I suggest you fork

@xzizka we are considering making it possible to send scan results to an API, but it not coming anyime soon.