Itay Raveh

Results 8 comments of Itay Raveh

Would love to be assigned this :)

Thanks! Just to be clear, Composer is an ABC, so I'm assuming the progress bar is for PGComposer.compose_pipline()?

> Thank you for the PR! I'll try to review this in the next week. > > I understand you've allowed snippet variables to be written in one of three...

> What's the intended behaviour when e.g. the snippet variables file is located inside the snippets folder? Or when the snippet variables folder is a subfolder of the snippets folder?...

> I'm imagining something like this: > > ```ts > const isSnippetsFile = settings.loadSnippetsFromFileOrFolder && isInFolder(file, snippetsFolder); > const isSnippetVariablesFile = settings.loadSnippetVariablesFromFileOrFolder && isInFolder(file, snippetVariablesFolder); > > // Process each...

Generally followed this procedure, with a few minor teaks. Set composition functions are [not available in Node.js](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set#browser_compatibility), so I installed pollyfills from [es-shims](https://github.com/es-shims) Both success and error notices are now...

Fixed all the formatting issues. Consider writing a [.prettierrc](https://prettier.io/docs/en/configuration.html) file matching your style :) As to the spam, I gave the notice a long debounce, and it's only created if...

> The upgrade to esbuild in [a04b339](https://github.com/artisticat1/obsidian-latex-suite/commit/a04b33920f90d4eefced78a1926b366e0e6d116c) causes the command `npm run build` to stall – any help? I'll revert the change temporarily so I can push out a release....