Isuru Fernando

Results 938 comments of Isuru Fernando

While the binaries provided in releases are python 3.5+ only, we do build and test with MinGW and MSVC 2015 for python 2.7 support. By 2020, we'll drop 2.7 support,...

> I'm discussing dropping support for MinGW and Python 3.5+ on windows. That's okay

Yes, I'm in favor of using `scikit-build` too. This PR has to be improved before merging though. Removing the `--symengine-dir` option to specify symengine C++ build directory limits my development...

I think we should have `Mod` with a rounding mode and the default will be `trunc` in C++ and `floor` in Python.

Yes, they haven't been wrapped in C yet. PRs are welcome.

You can use something like https://github.com/symengine/symengine/blob/6a6d68f0c0ffb1e73949975eae06b3220e2784bf/symengine/cwrapper.cpp#L613-L626 to wrap them in C.

Yes, that implementation predates the macro `IMPLEMENT_TWO_ARG_FUNC` and yes, we'd prefer using the macro.

you can define `conj(x::Basic) = real(x) - 1im * imag(x)` for now

> Is the Basic number type meant to be a real number? No, it's not. It's just that `conj` is not defined for `Basic` yet. (Because nobody needed `conj` until...