Isuru Fernando
Isuru Fernando
I think that the constructor with just the rows and cols should be made private. I assume that you want a zero matrix right? There's a `zeros` method for that.
You can create an empty matrix, but you can't print it.
Adding a check to all function calls to check if it's empty can be done in the python wrapper. Doing it in C++ to each function might be too costly.
There is `divides_upoly` at the moment which only give quotient. We can extend that API to give the remainder optionally.
Can you combine the headers `is_foo.h` into one header? There's really no reason to have a header with just one function in it. Also, I'm not a fan of adding...
This can't be done generally. FreeSymbolsVisitor is the only one that can ignore the subtree. For example `SubsVisitor` you need to store the value for the subtree, so a `uset_basic`...
It will be for SubsVisitor, but not for other visitors.
It depends on the visitor. You'll need to fix them one by one.
@xoviat, thanks for doing this. I wanted to check and fix scikit-build regarding https://github.com/symengine/symengine.py/pull/144#issuecomment-304048013 but I haven't had time to look at it. Do you know if they have been...
Will do tonight