old_mixer_repo

old_mixer_repo copied to clipboard

Feature Request - expression lang support

1

Use case: I am currently reporting the http path of each request to prometheus for monitoring. I noticed that the path contains the query parameters as well. i would like...

nmnellis

Docs for Mixer + Adapter Build Process

5

sakshigoel12

Improve test coverage of //pkg/runtime

2

https://codecov.io/gh/istio/mixer/tree/master/pkg/runtime There are some files in this package that should be fairly easy for which to improve coverage: - `env.go` - `init.go` - `logger.go` - `resourceType.go`

douglas-reid

https://codecov.io/gh/istio/mixer/tree/master/tools/codegen/pkg Some of this may require restructuring code but, in the near-term, we should investigate tickling at least some of the currently non-covered error handling code in the generation code.

douglas-reid

https://codecov.io/gh/istio/mixer/tree/master/pkg The files in `//pkg` could use some more unit test coverage. There is some low-hanging fruit in the files: - `api/grpcServer.go` - `status/status.go` - `template/template.go`

douglas-reid

cant add quotas with istioctl

5

@karmab commented on [Wed Sep 13 2017](https://github.com/istio/pilot/issues/1264) when running on top of openshift and trying to create a quota with ``` istioctl -v 10 mixer rule create global ratings.myproject.svc.cluster.local -f...

kyessenov

queue_test.go may be flaky

1

I've heard that sometimes pkg/config/store/queue_test.go can fail with the following log: ``` ==================== Test output for //pkg/config/store:go_default_test: (snip) --- FAIL: TestQueueCancelSync (0.00s) queue_test.go:149: Got name Want 8 queue_test.go:149: Got name...

jmuk

Both Prometheus and Stackdriver copy the [google.api.Distribution protos' BucketOptions](https://github.com/googleapis/googleapis/blob/a5e1f7d76c6779c1690e45649be31f4e96de68be/google/api/distribution.proto#L77-L145) message into their adapter config. We should just use the proto directly. [The blocker is that it includes unnecessary imports](https://github.com/googleapis/googleapis/blob/a5e1f7d76c6779c1690e45649be31f4e96de68be/google/api/distribution.proto#L19-L21 )....

ZackButcher

Pass context to the adapter during build

2

handlerBuilder.Build takes context.context object. where do we get it from into the runtime/handler .go code and config/handler.go code

guptasu

Mixer integration is only tested in istio/istio e2e tests at present. We need to replicate all those tests using Mixer + envoy only. 1. Integration test with real standard adapters...

mandarjog