Issack John
Issack John
## Safari: ## Edge:
@smfr I have a hosted version: https://neon-gumdrop-d49b03.netlify.app/?developerMode=&suites=Responsive-Design
Adding reviewers for visibility, feel free to take a look :)
> It seems to me that the test doesn't really take the advantage of responsive design since iframe's size is always same. Maybe we should add steps to resize iframe...
Gentle ping 😄
> I still see rather short run times for individual steps (close to 1.6ms in chrome canary) which might introduce a bit too much noise in the long run. >...
> Some visual questions - these might not be relevant to the tests: > > Is this spacing as expected? I'll add a fix for that. The webpage was designed...
> @issackjohn - maybe rebase / merge main, to get the updated test runner in there. That should ensure the checks don't fail. Sounds good.
> Let's aim for > 5ms for each measured subtest (I'd still aim for roughly 10ms if possible). Does this sound reasonable? Sounds reasonable to me, I'll add some more...
Thanks! Looking forward to addressing anymore feedback from folks.