Edgar Hernández

Results 97 comments of Edgar Hernández

@danielezonca > @israel-hdez Nice job with the PR, I have a couple of questions > > * What about a scenario where Knative/Istio are not installed when KServe is installed...

> * I would expect a proper error in the `InferenceService` status/event to mention that it is not possible to deploy I just added some code to abort reconciliation early...

@Jooho @terrytangyuan @spolti The code is ready. Please, do another review round. I added tests around the impacted `Reconcile` functions. I failed to find a way to add tests for...

@terrytangyuan @spolti I finally had time to finish this PR. Please, take another look at this.

I pushed an empty commit to re-run CI, which is now passing. @spolti @terrytangyuan Please, re-approve if you are still OK with this PR.

Per prow instructions: /assign @yuzisun

@yuzisun This is rebased to resolve conflicts, and CI is passing.

> @israel-hdez Can you help test whether this fixes the out-of-memory issue ? I'll test on my Wednesday.

> @israel-hdez Can you help test whether this fixes the out-of-memory issue ? @sivanantha321 I'm still replicating the setup. I tried today, and my cluster died while on it. I'll...