Edgar Hernández

Results 97 comments of Edgar Hernández

> Really? We are talking about a redirect url that the IDP has no opinion about and will use as-is. So-so. The IdP uses the redirect_url as-is as long as...

It is just a little bit more complicated that just doing `assert.NotEquals`. In case it happens to be plain text, it would be a string of a JSON document. Something...

@Morriz I'm wondering if this is still an issue for you? To my eye, there is a configuration issue, because the right config should look like: ```yaml spec: external_services: grafana:...

@Morriz Can you post the Kiali ConfigMap that is created by the operator? I'd need the whole ConfigMap. You can mask data as needed.

I indeed was thinking on targeting the tooltip for the enhancement and leave untouched the axis. But after re-reading my comment, I see I didn't give any clue that I'm...

> If the operator cannot determine what namespaces are included when istio uses discovery selectors I would rule out processing discovery selectors in the operator, because that would mean that...

> The following is an update based on recent UX discussions: > > ![image](https://user-images.githubusercontent.com/1286393/190476338-bbcd2b37-9f64-4495-9dac-6c855cd95b6d.png) Look at it... It's beautiful!

This looks related to Istio's preference of using "[Third party service account tokens](https://istio.io/latest/docs/ops/best-practices/security/#configure-third-party-service-account-tokens)", which is a Kubernetes feature that has been available in kubernetes for a while. Yes, I think...

@Xunzhuo Yes! You can take this issue.

@ldemailly We generally don't do back-ports unless a CVE is involved. Currently, Kiali is targeting Istio v1.15. It's simply because it is untested in older versions. Perhaps, just try and...