Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

MSVC Ninja fixes

Open dbs4261 opened this issue 5 months ago • 3 comments

Type

  • [x] Bug fix (non-breaking change which fixes an issue): Fixes #
  • [x] New feature (non-breaking change which adds functionality). Resolves #
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Not all windows builds use the MSVC generator, for example the CLion can be used as an IDE and dispatch to the MSVC compiler. MSVC creates different names for some libraries eg. libpng-d.lib. This does not happen with the Ninja generator, so these debug libraries cannot be found when using a different generator.

Checklist:

  • [ ] I have run python util/check_style.py --apply to apply Open3D code style to my code.
  • [ ] This PR changes Open3D behavior or adds new functionality.
    • [ ] Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is updated accordingly.
    • [ ] I have added or updated C++ and / or Python unit tests OR included test results (e.g. screenshots or numbers) here.
  • [x] I will follow up and update the code if CI fails.
  • [x] For fork PRs, I have selected Allow edits from maintainers.

Description

This PR has cmake check the generator instead of the compiler to determine if these different names should be added. Also updated the tbb target name that is copied for the test.exe target to its namespaced version TBB::tbb.

dbs4261 avatar Sep 12 '24 18:09 dbs4261