Open3D icon indicating copy to clipboard operation
Open3D copied to clipboard

VoxelBlockGrid update

Open theNded opened this issue 2 years ago • 4 comments

  • Provide Reset to address #4759
  • Provide Prune to recycle outlier blocks
  • Minor parameter adjustment for loading to avoid stdgpu hashmap overflow

This change is Reviewable

theNded avatar Feb 17 '22 19:02 theNded

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

update-docs[bot] avatar Feb 17 '22 19:02 update-docs[bot]

LGTM after fixing unit tests.

yxlao avatar Feb 18 '22 00:02 yxlao

Unit tests failed on CPU with ISPC turned on. Reason: when converting the bool result of element-wise boolean operations (eq, le, gt, etc) to scalars, True becomes 255 or equivalent while the expected result should be 1. It does not happen to conversions from created bool tensors to scalar tensors. Awaiting fix before merging.

theNded avatar Feb 18 '22 04:02 theNded

python -c "import open3d as o3d; print(o3d.core.Tensor.ones((3), o3d.core.int32).le(1).to(o3d.core.int32))"

When computing Tensor::Le() with ISPC, ISPC assigns 0b11111111 (255) for the true values. If we initialize a fresh tensor, the true value will always be 0b00000001.

Some discussions: https://stackoverflow.com/questions/51927616/c-bool-to-int-conversion-bug

yxlao avatar Feb 18 '22 10:02 yxlao

If we initialize a fresh tensor, the true value will always be 0b00000001.

Is this even the case when using ISPC for initializing a new tensor?

reyanshsolis avatar Sep 27 '22 14:09 reyanshsolis

Hi @theNded , do you have an update on this PR?

ssheorey avatar Jan 24 '23 17:01 ssheorey

Let me close it for now and reopen after some upgrades.

theNded avatar Jan 25 '23 16:01 theNded