MultiObjectiveOptimization icon indicating copy to clipboard operation
MultiObjectiveOptimization copied to clipboard

`iter_count` is never incremented in `min_norm_solvers`?

Open newalexander opened this issue 3 years ago • 0 comments

Both the find_min_norm_element (https://github.com/isl-org/MultiObjectiveOptimization/blob/master/multi_task/min_norm_solvers.py#L120) and find_min_norm_element_FW (https://github.com/isl-org/MultiObjectiveOptimization/blob/master/multi_task/min_norm_solvers.py#L166) functions define a while loop based on an iter_count variable.

Line 13 of Algorithm 2 in the paper (https://arxiv.org/pdf/1810.04650.pdf) notes that optimization is done until a number of iterations or convergence threshold is reached. However, the code never actually increments iter_count, and so optimization only terminates based on the convergence threshold.

newalexander avatar Aug 22 '21 16:08 newalexander