Daniel Richard G.
Daniel Richard G.
Is there an additional step needed for merging? Anything I need to do?
What is the status of development on this project? It does not appear to have received a commit, from anyone, for nearly a month.
@thakkarV: After 3.5.1 is fine; just want to make sure this gets in.
Hi @memsharded, > I have read #15268, but I still have some concerns, I'd need to understand better what would be failing because of unzipping with the current timestamps. Reproducible...
Rebased the commit. @memsharded, do you have any further concerns? This just brings the zip extractor into parity with the tar one; there isn't anything novel here.
> like zip files with wrong timestamps in origin, that result in dates in the future in disk, then things don't compile because it detects future dates. Couldn't that be...
> but it is working for them, and if we introduce this, their builds will start to fail Builds will fail with timestamps not being preserved---packages using GNU Autotools are...
It is frustrating to articulate concrete issues with the current handling of .zip file timestamps, and see them dismissed on grounds of breakage that *might* occur under extremely narrow circumstances...
Note that `ldconfig` only helps if the program is installed in a system location, like `/usr/local/lib/`. (And this requires root access, naturally.)
> So the [depot_tools.patch](https://github.com/ungoogled-software/ungoogled-chromium/blob/1602c44d38468e729826e8c1b1522042da159959/utils/depot_tools.patch) is broken in some way in newer version or the cloned depot_tools repo is broken/incompatible? I am unsure though as I couldn't get it to work....