Daniel Richard G.

Results 167 comments of Daniel Richard G.

The balance is now 101 pass, 29 fail. [Here](https://github.com/DanBloomberg/leptonica/files/3821637/leptonica-gplot-pnm.patch.txt) are some suggested changes to the gplot code so that it can write pnm, and fall back to same when png...

It's certainly getting better! Here is an initial set of tests that can be skipped: ``` Test name Skip due to call to... ================ ========================== boxa3_reg pixaGenerateFontFromString boxa4_reg pixaGenerateFontFromString ccthin2_reg...

Working late today... For `HAVE_*` symbols defined by Autoconf, yes: `#if defined(HAVE_FOO)` (or `#ifdef HAVE_FOO`) should be used. Because `HAVE_FOO` will take one of the following forms in the config...

Hi @thakkarV, is there a repo where I can try out the new version? I have some additional (non-warning) fixes for the current tree, so I'll push those out ASAP.

Hi @mhoemmen, thanks for looking at this. To help answer many of the above questions, let me provide you with an updated list of the warnings generated from my build,...

I've updated and rebased my PR. With these changes, the most frequent warning occurs 969 times.

Hello @mhoemmen, have you had a chance to try out these changes? I've rebased the PR to current main.

I think the oneAPI warnings on that bit come down to `operator[]` taking a `size_t`. Since overloading that with `int` doesn't appear to work, is there a way to declare...

Argh, this slipped through the cracks. My apologies. I was not able to reproduce those particular warnings in Godbolt. It is possible that the specific C++ backend in use has...

Please let me know if there are any further concerns here. My understanding is that the remaining changes are reasonable disambiguations that have not drawn any objections.