Ivan Shubin
Ivan Shubin
You are getting the error "Specified area is outside for original image" because you have horizontal scrollbars. Therefore the screenshot that Selenium creates is less then the actual area of...
@nplatonova now I see what the issue is. You were using the original icon from the website. If you open that sample icon you will see that it only has...
@nplatonova It seems like it it takes the incorrect area from the screenshot. Could you please post a complete html report generated by galen. I want to see how it...
@sourbhattacharjee No, this is not supported
Ah, so you mean it overwrites the `_primaryFields` and `_secondaryFields` ? Yeah, that's a stupid issue :) thanks for reporting it! I will fix it on master branch once I...
I think is line is incorrect https://github.com/galenframework/galen/blob/master/galen-core/src/main/resources/js/GalenPages.js#L103 It should merge those two fields instead of replacing them
Not sure why that fix should break anything? All I plan to fix is merging the _primaryFields and _secondaryFields on the extended page only, and not on the base page....
@JaniszM I think you have a point. To be fair, GalenPages was originally created when I didn't have enough experience with JavaScript. Right now I would probably rewrite it completely...
@hypery2k @JaniszM Thanks for proposal! TypeScript could be a good idea. Though I wouldn't jump into it so fast. The reason is I plan to extend Galen Framework into a...
Well I plan to make it a simple web server with json-based api. I have already made something like this but for a different purpose: https://github.com/ishubin/galen-ide In the end we...