Isaac Garzón

Results 59 comments of Isaac Garzón

@phkahler I took your code and created an initial draft of the scoping rules that you described and my idea of the parser changes in [a branch](https://github.com/iscgar/solvespace/tree/isaac/named-params-expr). Note that this...

> @iscgar I'm going to need some time to review what you're doing. At a glance it seems more invase, but a lot of the changes are small. Most of...

> I'm not sure what you mean by "request handling all over the place". The text window needs something - I do want to define them primarily in the text...

I cleaned up the code a bit, dropped the decoupling of `Expr` from the sketch for now, and implemented named parameter persistency [in a different branch](https://github.com/iscgar/solvespace/tree/iscgar/named-param-expr-clean). Please check it out...

> I cleaned up the code a bit, dropped the decoupling of `Expr` from the sketch for now, and implemented named parameter persistency [in a different branch](https://github.com/iscgar/solvespace/tree/iscgar/named-param-expr-clean). Please check it...

> @iscgar I have not had time yet. How does it handle names that only exist in an expression? Are they added to the group? At what index? No, you...

I implemented parameter locking functionality in my branch, and it's indeed very useful. While at it I also aligned parameter names and values in the text window to make it...

> Off topic: @iscgar by adding tooltips you've touched the infamous `TextWindow::Printf` - our "GUI framework " :-) - which has inspired some... passionate comments... in the past. Having used...

> @iscgar How did you implement the lock/unlock icons? I searched and couldn't find those in the unicode BMP :-) That's because they aren't standard BMP glyphs :) The way...