Isaac Garzón

Results 59 comments of Isaac Garzón

* Adding curly braces didn't make a change * Building with OpenMP support, but commenting out the `parallel for` directive in `SShell::CopySurfacesTrimAgainst()` does make it work * However, it breaks...

> Hmmm are we corrupting memory somehwre? Referencing stale/dangling pointers? > > With OpenMP off and sanitizers on (when it breaks) do the sanitizers complain about something? Nope. Only the...

> Question for everyone. What _exactly_ is happening in [this line of code](https://github.com/solvespace/solvespace/blob/74a13ef61c490a400eaa49c5335622d91ada12fc/src/srf/boolean.cpp#L703) > > The function call is returning a new surface, which is being copied via assignment into...

I think so. Since enabling UBSan alone (by passing `-DSANITIZERS=undefined` to cmake as I showed above) is enough to trigger the issue, debugging it in single threaded mode, while focusing...

Adding debug prints and comparing the state between a broken build and a working one shows the following diff: ```diff $ diff -Nura ok2.txt bad2.txt --- ok2.txt 2025-08-26 21:30:11.798839788 +0300...

I haven't been following the named parameters discussions too closely, so forgive my ignorance, but I'm not sure what the scoping rules are, so a clarification would be very much...

> @iscgar the current implementation does not follow sketch generation scope rules. The plan is to create a valid set of names for the current group when generating a sketch....

> @iscgar yes. See also the https://github.com/solvespace/solvespace/commits/parameters/ which is the "modern", unfinished implementation. And (in case you are not aware of it) the O.G. issue and discussion #77 > >...

> Are parameters that belong to constraints recreated on regeneration? Are they saved to files? (I think they probably are?) Currently parameters belong to requests, and the only constraint that...

> Parameters need to be saved in a file so the sketch has reasonable dimensions. When you draw a line the endpoints use 2 parameters each (x, y). The line...