Isaac White

Results 7 comments of Isaac White

Sounds great to me! Feel free to open a PR if you are interested in taking this on @mrSidSat.

This is a great idea! We could start by including the full markup of all subitems in the page, and add a bit of lightweight css/js on top of that...

We should also explore hiding stack traces for missing custom override files, which for anyone that has cloned the repo directly will not be present and are nonfatal.

Some other things we should try to cover, too, via #95 (🙌 , @tomcoombs!) >I did have single quotes here ... GOOGLE_APPLICATION_JSON='{"type": "service_ac ....... iceaccount.com"}' But I've taken them out...

Another error that could use better documentation, via the Google Group: ``` /Users/Documents/library-master/server/userAuth.js:12 [0] const domains = new Set(process.env.APPROVED_DOMAINS.split(/,\s?/g)) [0] ^ [0] [0] TypeError: Cannot read property 'split' of undefined...

Hey @thomasoide, thanks for flagging this. I think this is a bug in the interaction between Library's formatting logic and exported HTML from the Google Drive API. We should investigate...

- [ ] `approved_domains` needs better description in heroku yaml (should not default to nytimes.com, confusing. See: https://github.com/nytimes/library/blob/master/app.json#L40)