Sam Isaacson

Results 711 comments of Sam Isaacson

It was broken before with where the index was being placed, and now it is broken differently. I did explicitly mention this in my PR, but at least on my...

Also, in the PR all the MTK tests reported as passed? Only Catalyst tests failed and it was due to the other issues we were having this week there that...

If we want a simple temporary fix here until Latexify fixes the deeper issue, but don't want to drop `snakecase = true`, we could drop printing of the the argument...

@ChrisRackauckas what do you think about dropping the argument in all these expressions? Generally I find the MTK-generated DAEs are too verbose because of all the `(t)`'s that appear anyways,...

But maybe that isn't a great idea since in other contexts keeping the arguments is important.

Note that this causes this simple unit test to fail now: https://github.com/SciML/ModelingToolkit.jl/actions/runs/11250561770/job/31279691694?pr=3108#step:6:925 which is indicative that units in registered functions still have an issue that this was masking.

To record what has been investigated here, @TorkelE pointed out on Slack this seems to completely hang Julia: ```julia function testSI() t = ModelingToolkit.t_nounits D = ModelingToolkit.D_nounits @variables X(t) @parameters...

CC: https://github.com/SciML/StructuralIdentifiability.jl/issues/360

Docs and extension are fully disabled now via: https://github.com/SciML/Catalyst.jl/pull/1074#pullrequestreview-2357510018 so that will need to be reverted when it starts working again.

https://github.com/SciML/Catalyst.jl/pull/1077 gets us started by making it work on `Reaction`s.