Sam Isaacson
Sam Isaacson
It should be straightforward for a static model version as a first step, but we need to add MTK system support for it too. A simple callback-based dynamic version that...
@kaandocal you might want to update to the latest JumpProcesses as I found a bug with reinitializing the initial condition when calling `solve` many times in a loop.
https://github.com/SciML/ModelingToolkit.jl/pull/3181 should enable support for such models in MTK, and then we can add an interface here.
https://github.com/SciML/ModelingToolkit.jl/pull/3181 should add this to MTK, and https://github.com/SciML/Catalyst.jl/issues/1112 is where we will discuss the interface. This should, if setup correctly, be handled automatically, but may require some modification to the...
Closing as we will handle/discuss this in the new issue I linked.
We should just show how to write a callback that updates the `tstop`s correctly for the next event.
Relevant benchmarks to look at: Catalyst paper: https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1011530 SciMLBenchmarks: https://docs.sciml.ai/SciMLBenchmarksOutput/stable/ And probably we should cook up some hybrid models and variable rate jump models to test with too.
That sounds like a good list for what can be examined (more) easily.
Coveralls was out of date by 4 months, and CodeCov was just plain wrong (claiming no coverage on most aggregators).
These seem indicative of incorrectly specified initial conditions now that initialization is fixed, and I suspect of the issue reported in https://github.com/SciML/Catalyst.jl/issues/1057