Isaac Mason

Results 41 comments of Isaac Mason

Updated to address comments. This approach reverts back to using `setFromObject` and now removes vertices not included in the convex hull (interior vertices). I'll give this another pass shortly -...

Sorry, was busy for a sec! 🙂 Marking as ready for review now. I've done some testing and this PR looks good to go. As an aside, the generated shapes...

Ah that looks like it, thanks. And yep, not really a big issue when cannon itself isn't deterministic!

Thanks for the help @donmccurdy!

Happy to help with looking into this too - just need to find some time 🙂

Thanks @donmccurdy. It looks like this might be a duplicate of this issue: https://github.com/donmccurdy/three-to-cannon/issues/59 There's an interesting related `cannon-es` issue linked there: https://github.com/pmndrs/cannon-es/issues/103 I'll find some time to have a...

Potentially relevant: https://github.com/schteppe/cannon.js/issues/459#issuecomment-887939884 > Because of the way that cannon.js is programmed, if the convex triangles are not all connected, then convex-convex collision will not work.

Thanks @donmccurdy for the info! I think it's sent me down a good path 🙂 It looks like the issue may be in how `getConvexPolyhedronParameters` constructs faces? From reading [`ConvexPolyhedron.clipFaceAgainstHull`](https://github.com/pmndrs/cannon-es/blob/master/src/shapes/ConvexPolyhedron.ts#L472)...

> There's a lot in this library that could use serious refactoring and better unit tests, sorry for that. 😮‍💨 If you'd be interested in push access and just making...

Sorry, haven't had much time to progress this. I did however notice there's a new PR in the cannon-es repo for simplifying the creation of convex hulls: https://github.com/pmndrs/cannon-es/pull/155 I did...