Konrad Kuśnierz
Konrad Kuśnierz
It is a bug. It happens because of __index method within metatable of all derived classes which fallbacks to the base class and thus gets the handler from it. I...
He means replacing these two: https://github.com/edubart/otclient/blob/master/modules/corelib/util.lua#L56 https://github.com/edubart/otclient/blob/master/modules/corelib/util.lua#L65 ```lua if not object[signal] then ``` => ```lua if not rawget(object, signal) then ``` I thought about the same, but I wasn't sure...
Ah, I believe I do understand you now. You mean if local player triggers onPositionChange it should fire all handlers from both Creature and LocalPlayer, but instead it will only...
The code quality of mobile port is mediocre at best and it uses over complicated solutions. Personally I would never merge it unless adequate technique* to approach such port is...
I meant the platform specific window creation code available here: https://github.com/edubart/otclient/tree/master/src/framework/platform It can be replaced by a single SDL2 window creation code. That being the case it is trivial task...
It happens because A* algorithm tries to calculate the path until it hits the limit. In general it is not a bug, but since those calculations are quite heavy it...
Game server does calculate the path within the creature view only, so it is hardly a demanding task. However, in the game client we do calculate a lot more outside...
You are correct. It's safe to remove that part. However, I do not believe we can read 8-bytes long signed value because of the following part in unpack: ``` lua...
Actually 8-bytes integer can hold only up to 2^64 - 1, while 2^64 is an overflow. I have no idea (yet) what to do about it. The problem is that...
This is why I never fixed this issue. I might as well just remove any 8-byte integer handling code from lua-struct and leave maximum 4-byte long integer values (which can...