Irvanal Haq

Results 17 comments of Irvanal Haq

It seems that the method `.default_numbers_to_display()` has been removed from Manim Community, but the code wasn't updated accordingly. If your goal is to display numbers along the number line, you...

Hi @kevinnadar22 I think this issue still needs to be addressed. When users call `.get_number_mobjects()` or `.get_labels()` on a `NumberLine` object, it will still raise an `AttributeError` because `.default_numbers_to_display()` is...

Hi @ccalauzenes Thanks for reviewing. You're right. The method `.set_stroke()` should only be applied to the mobject, not to its submobjects. I have fixed it by adding `family=False`. Test: ```python...

Hi @JasonGrace2282, Thank you for your feedback. I have added tests to cover this behavior. The tests can be found in `tests/module/mobject/geometry/test_unit_geometry.py`. They specifically verify that: 1. The side_length property...

Please let me know if there are any additional changes or if further testing is needed. Thanks!

The test seems to fail on Mac. But I think that's because of `floating-point` on Mac, not because the code breaks other codes. I hope this pull request can be...

Hi @JasonGrace2282 , I hope you're doing well! I wanted to check in on the status of my pull request [#3901](https://github.com/ManimCommunity/manim/pull/3901). Is there anything else I can do or address...

> I think the change itself is fine - I've seen enough confusion about this that it's probably better to make it a property. > > However, the tests should...

Hi @JasonGrace2282, I wanted to let you know that I’ve addressed the floating-point precision issue based on your suggestions. All the tests are now passing successfully. It seems that I...

> Seems fine to me, thanks. Thanks for your help and feedback throughout this process.