Igor Rončević

Results 89 comments of Igor Rončević

Thanks for the early feedback and excellent questions @tritao! This issue description indeed requires more elaboration including the proper definitions and more concrete examples of measurements that justify proposed design....

> So we won't be translating it to jumps? but just a more efficient form of if-else structures. ~~I pondered about this a lot. Right now we do not have...

Hmmm, revoking my thoughts and rethinking it 🤔 Our IR is MIR. Which means we could bring match expressions all the way down to it and do the jumps there....

> I'm guessing that if we do that, we'll need a switch construct in the IR Yes we will need `switch` in that case. > Until the support is there,...

To sum up the discussion so far, we have two options with different tradeoffs: 1) Stay on the current path and desugar match expression into `if-else` and other constructs already...

Thanks for the feedback @vaivaswatha @tritao! Let's sleep over it and see. In the first step I want to fix the open issues that we have in the phases that...

@IGI-111 From my side this PR is approved quite some time ago. Can we get a second review and approval?

As discussed, converting to draft until we get some initial infrastructure for feature flags as discussed in the [RFC on bringing changes to the compiler](https://github.com/FuelLabs/sway-rfcs/pull/41)

I highly appreciate the effort put into the comprehensive PR description! :pray: :heart:

**EDIT: The transient bug whose symptoms are described below is now fixed. The issue was in an already existing (long existing :wink:) underlying bug in the `PartialEqWithEngines` implementation for the...