Igor Rončević

Results 59 comments of Igor Rončević

Here is the progress so far and two open questions to agree on. Please provide your feedback on the questions. # Before and after :-) ![01A Constant shadowing - Before](https://github.com/FuelLabs/sway/assets/4142833/97e70a69-de62-4c86-b4a4-9e03deaf3a22)...

Completely agree that the terminology is very confusing. I wasn't happy with it either, especially when modeling the corresponding structs in code (`CompilerMessage` having field `message` of type `InSourceMessage` :scream:...

For the record, a very inspiring paper titled [Concepts Error Messages for Humans](https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2429r0.pdf). It emphasize the importance of good (great!) error messages and provides concrete tips how to formulate them....

Hi, this looks like a _great_ first issue, not only a good one :-) I would love to contribute to it. I have two questions, before starting with the implementation....

As explained in the comment above, the detailed list of _item-style shadowing_ and _sequential shadowing_ cases possible in Sway. I hope I didn't miss something :-) Parts **marked bold** are...

Great, thanks for clarification! I'll proceed accordingly.

Another one edge-case to consider. `use` importing has completely different error message at the moment: The name "LIB_X" shadows another symbol with the same name. In the case of _item-style...

It turned out that in also in this case, there is no error message at the moment for this case, same like in the comment above with `let`s: ``` const...

As explained in #5562 `deterministically_aborts` tried to compensate for the missing bottom type in the type system. Since we want to introduce it, there will be no need for fixing...

> So the examples are not self-contained Exactly, they are more like code snippets.