Irit Katriel
Irit Katriel
When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
I have made the requested changes; please review again.
> I'm confused by having both `PyMonitoring_EnterScope` and `PyUnstable_Monitoring_EnterScope`. The Unstable one is optimized ( > I'm confused by having both `PyMonitoring_EnterScope` and `PyUnstable_Monitoring_EnterScope`. I don't see a reason to...
> This is a very big addition to the limited API & stable ABI. Does it need to be added there? I've been wondering too. Should we keep this simpler...
@scoder @encukou @markshannon I removed the limited API part, so now we just have the inlined version. Can we all agree on this?
I have made the requested changes; please review again.
> Not as it is, as there's no documentation. Without that it's hard to tell if the API does what it should do, or what _codelike_ or _version_ should be....
`BaseException` is a builtin, I don't think you can add methods to it without a PEP.
I wonder why you believe it makes sense to add this as a method of `BaseException` rather than a utility function (say add this to the stdlib somewhere)? ``` def...
I see where you're coming from, but I'm uneasy about adding Group semantics to BaseException. Definitely needs a PEP, IMO.