Irit Katriel
Irit Katriel
> Did some more bisecting today. At least for Home Assistant the change that does appear to fix all ValueErrors seems to be > > * [gh-100762: Fix optimization in...
How does it fail? Can you provide a reproducer and add a unit test to the PR?
> @iritkatriel perhaps you have some idea? Did https://github.com/python/cpython/pull/107780 help?
I'd imagine the adjustment is to change the finally body to: ``` if coro is not None: coro = eventlet.getcurrent() self._spawn_done(coro) ```
> I mean, would you like to submit a pull request to fix it? Don't wait for me, go ahead.
I'm not using this code. I am doing static analysis of many open source projects to understand usages of finally (and incidentally reporting problems when I see them).
> I considered it acceptable because I thought that try-block would only raise an IndexError at the end of the input string. If your intention is to swallow all exceptions,...
> Thanks for reporting. And I'm a bit curious if you are working on a linting tool or if you are involved in some statistical research? I would love to...
> Do I understand correctly that the CodeLike type is expected to be provided by user code? I think we should provide CodeLike in some form, but for now I...
> Finally, maybe we should add a `PyMonitoring_ExitScope`, as it would allow the VM to track the current code-like object? What do you mean by track?