Irfan Ur Rehman

Results 12 comments of Irfan Ur Rehman

I can think of several usecase around this. - The retention can be specified once and applied globally to all resources of a specific federatedType - It can be specified...

@msdolbey I will take a look at this. You will have to give me few days though... :-) In the interim, do you want to try bumping the version and...

@msdolbey I fixed some test flakes last weekend. Can you please rebase your changes on latest. Also did you get time to address @makkes comments.

Just noticed this, will check it out over the weekend

@FengXingYuXin Thanks for doing this. Will it be possible for you to add some kind of a test for this change?

> @FengXingYuXin Thanks for doing this. Will it be possible for you to add some kind of a test for this change? @FengXingYuXin nevermind, there are unit tests for this...

> @irfanurrehman about the moment of status translates, for example, if fail threshold is 3, as I understand it, if it's better for translating status from ready to notReady when...

@mvaalexp please rebase this on latest, which is needed for the tests to pass.

@mvaalexp Please squash the commits also. Thanks!

@mvaalexp Squash commits needed, Thanks!