Irfan Ömür

Results 78 comments of Irfan Ömür

@antonis, is your investigation ongoing? Can I assign this issue and [WORDPRESS-ANDROID-2WA6](https://a8c.sentry.io/issues/5083633345/?referrer=github_integration) to you?

`site` is already being checked in `onCreate` and the activity is finished if the site is null. The crash message is `Attempt to invoke virtual method 'void org.wordpress.android.ui.bloggingreminders.BloggingRemindersViewModel.onBlogSettingsItemClicked(int)' on a...

> For future reference, how do we decide which bug/crash fixes to include there? I usually add every change that affects users to release notes, but if it's a minor...

I made the same change as you (added `NonNull` to lines 196 and 200), and but I received an error in `NotificationsDetailListFragment.kt` couldn't build. I'm not sure why you didn't...

> > Remove Progress dialog being shown during adding category as it's a deprecated component > > I believe Progress Dialog is no longer used in Add Category. When you...

Thanks @neeldoshii! Please mention in your PRs when they're ready to review.

Thanks, @neeldoshii! This sounds like a good plan. We are already using your suggested way in the "Invite People" screen, [TextInputLayout](https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/WordPress/src/main/res/layout/people_invite_fragment.xml#L91-L97) with `ExposedDropdownMenu` style. You can use the same.

Reopening this issue since I can reproduce it on version 24.9. https://github.com/wordpress-mobile/WordPress-Android/assets/2471769/c9e6970f-43d2-435a-9168-889bc666f1fc

"Thank you for the great analysis, @ParaskP7! 🤍 I would like to expand on the discussion and ask, "Have we considered migrating to [DataStore](https://developer.android.com/topic/libraries/architecture/datastore)"? I did some quick research and...

So, this issue is not related to `SharedPreferences`. 😅 It does not affect this issue and should be submitted as a completely separate PR. Thank you for clarifying my confusion...