Ivan Petkov

Results 154 comments of Ivan Petkov

Overriding `craneUtils` will become possible once https://github.com/ipetkov/crane/pull/652 lands!

Hi @Jisu-Woniu we already [have a `From` impl to convert `std::process::Command` to `tokio::process::Command`](https://docs.rs/tokio/latest/tokio/process/struct.Command.html#impl-From%3CCommand%3E-for-Command) which should do what you are asking for! For example: ```rust let mut cmd = std::process::Command::new("echo"); cmd.args(["hello",...

My initial thought was that exposing `as_std_mut()` could allow the caller to make changes to the underlying `Command` without our version knowing. I thought we used to have logic whenever...

Did some digging in the `magic-nix-cache` sources, looks like any new store paths get uploaded which does not take into account whether the upstream cache(s) also include it https://github.com/DeterminateSystems/magic-nix-cache/blob/a2eb0c6759c08aa7b288708effccf9047a1bb525/magic-nix-cache/src/api.rs#L52-L57

> cannot be updated is expected because it depends on the settings of the flake registry. @SuperSandro2000 I'm not sure I understand what you are saying here? The flake [uses...

Should be fixed with https://github.com/jj-vcs/jj/pull/7192

Hi @sellout thanks for the report! > I often want to take advantage of filterCargoSources, etc. in a context where I have to jump through hoops to get pkgs. The...

> The less frustrating cases are contexts like `overlays` and system-specific outputs like `packages` and `checks`, where you just need to pass in `final` or `pkgs` to those terms that...

@guskovd you can set `doCheck = false;` in your `buildPackage` derivation, and directly use [`craneLib.cargoTest`](https://github.com/ipetkov/crane/blob/a5eca68a2cf11adb32787fc141cddd29ac8eb79c/docs/API.md#cranelibcargotest) or [`craneLib.cargoNextest`](https://github.com/ipetkov/crane/blob/a5eca68a2cf11adb32787fc141cddd29ac8eb79c/docs/API.md#cranelibcargonextest) to run the tests both of which should automatically find any test binaries...

We mirror the behavior of the standard library here: ([example of the same behavior with using only `std` code](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=feb9060b8bfb8f691798162f7f115421)) > Similar to the behavior to the standard library, and unlike...