Ivan Petkov

Results 154 comments of Ivan Petkov

@Philipp-M It's up to you! I decided to pick the low hanging fruit so we could make incremental updates. Feel free to explore the .so linking optimization in this PR...

@dpc fwiw this PR's symlinking only happens when _inheriting existing artifacts_ to perform a build, but is entirely unrelated with how the _resulting artifacts_ are organized in `/nix/store`

I believe nixpkgs has a `removeReferencesTo` (forget if it's a hook or a package) which can be used to remove arbitrary references to things The only assumptions we currently make...

Couple of thoughts: --- Regarding efficient `removeReferencesTo`: I definitely agree it would be beneficial to have an optimized version which can do a bulk removal. The version in `nixpkgs` is...

> Executing cargoBuildHook Are you building with `crane` or using the upstream `rustPlatform.buildPackage`? `cargoBuildHook` comes from the latter, but I can't say more without looking at the configuration for this...

Hi @endocrimes thanks for the report! I'm assuming you've probably come across https://github.com/ipetkov/crane/pull/271#issuecomment-1475387702 since your analysis about the WIT files being in the parent directory being the problem is spot...

@musjj We don't have a first class way of doing that atm, though you may be able to [apply an override for downloadCargoPackageFromGit](https://crane.dev/advanced/overriding-function-behavior.html)

With https://github.com/ipetkov/crane/pull/615 we will have a general purpose mechanism for overriding (patching) any arbitrary crate sources! Hopefully it should make it easier to work around little quirks like moving files...

Here's a quick start snippet for how to patch dependencies: https://crane.dev/patching_dependency_sources.html

Hi @j-baker thanks for the PR! One bit of hesitation I have with the current direction is that it ends up pessimizing dependency handling for the "default" case (of not...