Ian Candy

Results 8 comments of Ian Candy

Still WIP, but we started working on a fix here: https://github.com/ipc103/primer-react/commit/f472da25d4f1ff48326c0056aa1696c9c94b4f81 Next steps: - Refactor the duplicated logic - Add a couple of additional test cases - Maybe support other...

👋 Thanks for opening this issue - we ran into this exact issue. I'm happy to take a look at updating the filter to account for aliased methods if that...

Thanks @siddharthkp! Let me know if/how I can help.

It does seem like some of those are related to this PR. I wonder if there are spots where we're working around the current behavior, or otherwise depending on it....

Looking more closely I'm not convinced those failures are related. They seem to be about unrelated components. I'm going to re-run just to make sure they aren't flakes or something.

Thanks @siddharthkp - that should work for us. The workaround is to just make sure that the list is memoized, so we can keep that up in the meantime.

@siddharthkp 👋 Hi! What do you think about this one - any chance we could cut another integration test branch and see if this change plays more nicely with the...

@siddharthkp I went ahead and created a new integration PR: https://github.com/github/github/pull/325842 I used the latest release candidate since it seems like canary builds are on pause at the moment. Did...