ipc-toolkit icon indicating copy to clipboard operation
ipc-toolkit copied to clipboard

Adhesion

Open zfergus opened this issue 1 year ago • 1 comments
trafficstars

Description

Implement the adhesion potentials from "Augmented Incremental Potential Contact for Sticky Interactions" [Fang et al. 2023].

Type of change

  • [x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [x] New unit tests

Test Configuration:

  • OS and version: macOS 14.2
  • Compile and version: Apple clang version 15.0.0

Checklist:

  • [x] I have followed the project style guide
  • [x] My code follows the clang-format style guidelines of this project
  • [ ] I have performed a self-review of my code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

zfergus avatar Dec 15 '23 07:12 zfergus

Codecov Report

Attention: Patch coverage is 94.49378% with 31 lines in your changes missing coverage. Please review.

Project coverage is 96.54%. Comparing base (416cdd4) to head (1a6ce44).

Files Patch % Lines
src/ipc/collisions/normal/normal_collision.cpp 30.00% 7 Missing :warning:
src/ipc/potentials/tangential_potential.cpp 96.74% 7 Missing :warning:
...c/ipc/potentials/tangential_adhesion_potential.cpp 40.00% 6 Missing :warning:
...c/ipc/potentials/tangential_adhesion_potential.hpp 57.14% 3 Missing :warning:
src/ipc/collisions/tangential/vertex_vertex.cpp 83.33% 2 Missing :warning:
src/ipc/collisions/tangential/edge_edge.hpp 0.00% 1 Missing :warning:
src/ipc/collisions/tangential/edge_vertex.hpp 0.00% 1 Missing :warning:
src/ipc/collisions/tangential/face_vertex.hpp 0.00% 1 Missing :warning:
...ipc/collisions/tangential/tangential_collision.hpp 50.00% 1 Missing :warning:
src/ipc/collisions/tangential/vertex_vertex.hpp 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   96.12%   96.54%   +0.42%     
==========================================
  Files         102      109       +7     
  Lines        7584     7708     +124     
==========================================
+ Hits         7290     7442     +152     
+ Misses        294      266      -28     
Flag Coverage Δ
unittests 96.54% <94.49%> (+0.42%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 15 '23 07:12 codecov[bot]