Isern Palaus

Results 8 comments of Isern Palaus

That would be a good to have, feel free to open a pull request. Btw, I'll probably wait and review #23 or #25 and move to PSR-2 merging them.

Hey @carlituxman, I'll try to give it a go this week but I'm a little bit busy. Even tho, it's weird that allCountries.txt is the file that gives the error...

Well, that's normal as it's an intense use. I'm not sure a `ini_set()` should be in the core. I'm pretty sure my php.ini for CLI has a no memory limit....

Can you do a local edit to https://github.com/ipalaus/geonames/blob/master/src/Commands/ImportCommand.php#L234 ? Add the memory limit command after the php execution and try.

This library is abandoned. I haven't updated since 2018 and I don't plan to. You should look for an alternative. Thank you

@nitper sorry for the delay, looks that we need to import illumiante/support in order to make the tests pass. Use the facade `Illuminate\Support\Facades\DB` should get the tests green. Do you...

I'll review it tomorrow morning, sorry for the delay @Morgon! Thanks in advance

Sorry about this @Morgon, can you ping me on IRC anytime today or tomorrow?